🐛 fix incognito scans #3518
🐛 fix incognito scans #3518
Conversation
Signed-off-by: Ivan Milchev <[email protected]>
Signed-off-by: Ivan Milchev <[email protected]>
Test Results2 849 tests ±0 2 848 ✅ ±0 1m 11s ⏱️ -2s Results for commit 938ed2b. ± Comparison against base commit f82f59d. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
| if err != nil { | ||
| return nil, err | ||
| // If we run in debug mode, download the asset bundle and dump it to disk | ||
| if val, ok := os.LookupEnv("DEBUG"); ok && (val == "1" || val == "true") { |
There was a problem hiding this comment.
Can we not use the same logic as in here
Lines 44 to 46 in 1b98d7f
There was a problem hiding this comment.
we only dump this if the env var DEBUG=1 is set. I think log.Debug().Enabled() is also true when we just have --log-level debug. I don't think we want to have these files in that case.
That same condition exists in cnspec for dumping the bundle there too. I just used the same approach
There was a problem hiding this comment.
temporarily ok, but we need to extract this into a function. Otherwise it will be hard to change that in the future https://github.com/mondoohq/cnquery/blob/main/logger/debug.go#L77
Signed-off-by: Ivan Milchev <[email protected]>
fixes #3502